Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make latitude, longitude, altitude and time settable via the web UI #124

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

mrosseel
Copy link
Collaborator

This helps in case of either forgetting your GPS dongle, or having a malfunctioning internal GPS.

Possible future work:

  • it might be nice to have preset locations like HOME, Observatory, ... similar to how the different wifi networks are configured.

@mrosseel mrosseel requested a review from brickbots January 17, 2024 14:45
Copy link
Owner

@brickbots brickbots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working to add this! I'm excited to actually try this and see how it works in context.

@@ -25,6 +26,7 @@
<li><a href="/">Home</a></li>
<li><a href="/remote">Remote</a></li>
<li><a href="/network">Network Setup</a></li>
<li><a href="/gps">GPS Setup</a></li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this on the 'Tools' page as it should (ideally) be rarely used. I know it's come up a lot in the discord (people not using GPS, issues with locks), but I hope these are not a representative sample of users. If people are using this often I have failed in some significant way as it's absolutely NOT the intended (or a good) user experience.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then I'd need to integrate it with the Tools page, and it's a lot of code, tools might become a garbage bin then. Maybe not adding it to the menu is enough? On save it returns to home

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... tools is probably not the right place. How about not on the menu, but accessible from the main page via the edit icon?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I did in the last commit

@@ -18,6 +18,7 @@
<i class="material-icons medium">{{gps_icon}}</i>
</td>
<td class="grey-text text-lighten-1">{{gps_text}}<br>lat: {{lat_text}} / lon: {{lon_text}}</td>
<td><a href="/gps" class="grey-text"><i class="material-icons">edit</i></a></td>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @mrosseel I missed this edit to the index page! Merging now!

@brickbots brickbots merged commit 648b86a into brickbots:main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants