-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. Skysafari pushto #113
1. Skysafari pushto #113
Conversation
…ntegration still todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! There is A LOT here, thanks for all the hard work 🥇 I very much appreciate your continued dedication to type hinting, I'm still planning on adding mypy checking to our workflow at some point and it's nice to have some of the code base up to snuff.
There are some things here (history vs. observing list) that will eventually phase out, but solidifying the ui state into an object and moving it to the shared state is good to have done.
I think we should merge this as soon as the bookworm stuff is ready. I don't think anything I'm doing there will conflict, so it should be easy to get all these branches merged into main when ready!
GoTo on skysafari now sends the coords to the pifinder, which shows it in a locate screen.
Known issue: