Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Skysafari pushto #113

Merged
merged 25 commits into from
Jan 20, 2024
Merged

1. Skysafari pushto #113

merged 25 commits into from
Jan 20, 2024

Conversation

mrosseel
Copy link
Collaborator

@mrosseel mrosseel commented Nov 13, 2023

GoTo on skysafari now sends the coords to the pifinder, which shows it in a locate screen.

  • Created a UiState which is now in the shared_state, because the pos_server runs in another thread and needs to communicate the new target position to the rest of the application
  • Added necessary handling of the goto message from skysafari to pos_server
  • refactored Catalogs for easier handling of pushto target and future developments

Known issue:

  • there's a crash in the push cat / push near objects methods, fixed in the planets PR (messy to backport)

@mrosseel mrosseel changed the base branch from release to main November 13, 2023 22:28
@mrosseel mrosseel marked this pull request as draft November 13, 2023 22:31
@mrosseel mrosseel changed the title [WIP] Skysafari pushto Skysafari pushto Dec 29, 2023
@mrosseel mrosseel requested a review from brickbots December 29, 2023 23:01
@mrosseel mrosseel marked this pull request as ready for review December 30, 2023 11:43
@mrosseel mrosseel changed the title Skysafari pushto 1. Skysafari pushto Dec 30, 2023
@mrosseel mrosseel changed the title 1. Skysafari pushto [WIP] 1. Skysafari pushto Dec 30, 2023
@mrosseel mrosseel changed the title [WIP] 1. Skysafari pushto 1. Skysafari pushto Dec 30, 2023
Copy link
Owner

@brickbots brickbots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! There is A LOT here, thanks for all the hard work 🥇 I very much appreciate your continued dedication to type hinting, I'm still planning on adding mypy checking to our workflow at some point and it's nice to have some of the code base up to snuff.

There are some things here (history vs. observing list) that will eventually phase out, but solidifying the ui state into an object and moving it to the shared state is good to have done.

I think we should merge this as soon as the bookworm stuff is ready. I don't think anything I'm doing there will conflict, so it should be easy to get all these branches merged into main when ready!

@brickbots brickbots merged commit a507736 into brickbots:main Jan 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants