Merge pull request #149 from mrosseel/rasc-double-stars

Adjustments of description text, added glossary, fix menu bug
brickbots · Mar 4, 2024 · c062af8 · c062af8
2 parents 74fd45e + 051ca3e
commit c062af8
Show file tree

Hide file tree

Showing 8 changed files with 11,125 additions and 387 deletions.
diff --git a/astro_data/RASC_DoubleStars/rasc_double_stars.csv b/astro_data/RASC_DoubleStars/rasc_double_stars.csv
diff --git a/astro_data/RASC_DoubleStars/rasc_double_stars.ipynb b/astro_data/RASC_DoubleStars/rasc_double_stars.ipynb
diff --git a/astro_data/RASC_DoubleStars/rasc_double_stars_full.csv b/astro_data/RASC_DoubleStars/rasc_double_stars_full.csv
diff --git a/astro_data/RASC_DoubleStars/rasc_ds.desc b/astro_data/RASC_DoubleStars/rasc_ds.desc
@@ -6,4 +6,19 @@ The program can be started at any time and easily completed within 12 months.
 
 It encourages intermediate visual observers to view a variety of doubles and multi-star systems.
 
+Abbreviations:
+Opt = Optical
+Phy = Physical
+?   = Uncertain
+Bin = Binary
+Win = Winter
+Spr = Spring
+Sum = Summer
+Aut = Autumn
+Sep = recent Separation
+PA  = recent Position Angle
+M   = Magnitude
+
+Note: only certain pairs (e.g. AB or AC) need to be observed to get the certificate.
+
 More info on https://www.rasc.ca/double-stars
diff --git a/astro_data/pifinder_objects.db b/astro_data/pifinder_objects.db
diff --git a/python/PiFinder/menu.py b/python/PiFinder/menu.py
@@ -56,13 +56,14 @@ def get_options_window(self):
         # Ensure self.current_pos is within the bounds of the self.menu_items
         # If all menu options fit within the visible window, no need to scroll
         if len(self.menu_items) <= self.visible_count:
-            return self.menu_items, 0, len(self.menu_items)
+            return self.menu_items
 
         # Highlighted item causes the window to move to include the item
         self.start_index = self.current_pos
         self.end_index = self.start_index + self.visible_count
 
         # Return the slice of menu options to display, along with start and end indices
+
         return self.menu_items[self.start_index : self.end_index]
 
     def __str__(self):

diff --git a/python/PiFinder/ui/config.py b/python/PiFinder/ui/config.py
@@ -113,7 +113,6 @@ def update(self, force=False):
                 if "enum" in selected_item["type"]:
                     self.__menu.set_items(selected_item["options"])
                     options = self.__menu.get_options_window()
-                    # print(self.__menu, selected_item)
 
                     # Show the options
                     for i, enum in enumerate(options):

diff --git a/python/tests.sh b/python/tests.sh
@@ -0,0 +1 @@
+python3 -m unittest discover -s tests