LPD-24920 Implements the new ClayTable component to FDS #151748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new ClayTable component now handles more responsibilities and has a new improved and less verbose DX removing the excess drilling prop and verbosity of the old component as well as OOTB features such as nested row, sorting columns and visibility columns the component is accessibility first. This is under feature flag and still WIP, in this initial implementation we are not adding the column resizer feature we will use the same FDS implementation while we did not work on it in Clay. We also need to do some more nested row tests and add a new row with inline edit.
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-24920 1 Successful Jobs:For more details click here. |
✔️ ci:test:stable - 32 out of 32 jobs passed✔️ ci:test:relevant - 41 out of 42 jobs passed in 1 hour 32 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: abc4222371a1a253ae05ecb3e6083858ac965415 ci:test:stable - 32 out of 32 jobs PASSED32 Successful Jobs:ci:test:relevant - 40 out of 42 jobs PASSED2 Failed Jobs:
40 Successful Jobs:For more details click here.This pull contains no unique failures.Test bundle downloads:
|
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-platform-experience#602 (Took 3
ci:forwardattempts in 5 days 13 hours 38 minutes)Console
@matuzalemsteles
@liferay-platform-experience
Original pull request comment:
The new ClayTable component now handles more responsibilities and has a new improved and less verbose DX removing the excess drilling prop and verbosity of the old component as well as OOTB features such as nested row, sorting columns and visibility columns the component is accessibility first.
This is under feature flag and still WIP, in this initial implementation we are not adding the column resizer feature we will use the same FDS implementation while we did not work on it in Clay.
We also need to do some more nested row tests and add a new row with inline edit. We need to wait for the Clay #600 release PR to come in so we can do more tests with the fixes I sent to Clay.
After that I will add some before and after screenshots showing the features.