Downloaded content changes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added @stoletheminerals for security/privacy concerns |
deeppandya
commented
Nov 22, 2023
src/main/java/com/brave/playlist/playback_service/VideoPlaybackService.kt
Show resolved
Hide resolved
|
@deeppandya does that PR have anything new or what the actual changes? As from what I see it's basically some kind of a rebase of old commits. Do we need to review everything or just certain commits? |
@SergeyZhukovsky I have changed the implementation to work with his content differently. This kotlin module is mainly for the UI and player interaction. I would be better if you can briefly go over the changes as I have changed almost every files with new changes. I am sorry for the trouble but there is no easy way for it. |
tapanmodh
suggested changes
Jan 4, 2024
BottomSheet UI Fixes Exoplayer Added.
Finish flow from the web page to player
Update interaction Remove activities and create fragments instead Update existing code to work with rename functionality
Update option icons Add option to delete playlist
Address notification changes for android12,13
Add cast with platlist Add media session deps Update code for all playlists
Add check for expire content Add playlist menu onboarding Update playlist options enums
Set default plalist update Update menu interactions Resolve full screen UI Rename playlist option Online/Offline mode update
Update move/copy functions Update behavioural changes
Update default playlist behaviour
Update thumbnail images Update onboarding text Update strings based on feedback Update utils Format code
Resolve filesize Refactor code Rempove json dependency Refactor code
Add local db update few behavioural changes
Update onboarding code Resolve playback service issue Update tablet UI Resolve double playback issue Remove currently playes song Update changes for playlist service Update player notification adapter Update playlist icon tint
Update icon tint for light mode Add tint to current playing item Update onboarding Add exoplayer hls dependency Add HLS support
Update minor ui changes Update gradle file for aar signing Update private variables Remove commented code
Apply changes to hide playlist button Update tint color for hide icon
Address security concerns Add newline Address PR comments
Add test HLS to assets Update warnings
Update hlsMediaPath after download Update existing changes with hls file
Resolve rebase issue with requireActivity on back press
Resolve media session issue
Reformat code Remove offline option form playlist item swipe
Update onboarding rounded bg
Refactor and remove unused commented changes
Update player bottom sheet behaviour
Add schema location
Changes related to delete while playing
deeppandya
force-pushed
the
downloaded_content_changes
branch
from
cd21306 to
2c85d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.