-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standard-js module added #76
base: standardjs
Are you sure you want to change the base?
Conversation
Change-Id: I2dab3eafdd2b626310521a22bc82b09d6988d23f
This is a strange! You removing all |
I have added the same library that we use in corbel-composr. this util format all the code following the standardjs. The problem is that we have to use ecma6 because we have to modularize some files. That is because the pull request was made in other branch. |
Ok, but leave the |
Sorry but it's an autoformat tool, I can't choose that option :( |
Well, if we want to use it on corbel-js we all need to agree to use it otherwise we will be causing git conflicts with each other. Also, I guest we need to make changes in the jsHint config for it not to complain. @rafinskipg @anthanh what do you think? |
hi @alexdeleon , we have stopped using jshint in favour of standardjs , the gruntfile now includes the autoformatter so no more space/tab problems. But we are thinking in migrate corbel-js to es6 modules and use babel to ensure browser compatibility and also minify the dist. The point for the migration of the modules is being able to require isolated files and make better unit tests |
Ok then, if it doesn't cause any issues in the browser then lets migrate to this code style. |
Change-Id: I2dab3eafdd2b626310521a22bc82b09d6988d23f