Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard-js module added #76

Open
wants to merge 1 commit into
base: standardjs
Choose a base branch
from
Open

Conversation

rackdon
Copy link
Contributor

@rackdon rackdon commented Feb 15, 2016

Change-Id: I2dab3eafdd2b626310521a22bc82b09d6988d23f

Change-Id: I2dab3eafdd2b626310521a22bc82b09d6988d23f
@alexdeleon
Copy link
Contributor

This is a strange! You removing all ; and doing a bunch of formatting . Please check your IDE and fix it. Try not to change so many files. It is hard to review :)

@rackdon
Copy link
Contributor Author

rackdon commented Feb 15, 2016

I have added the same library that we use in corbel-composr. this util format all the code following the standardjs. The problem is that we have to use ecma6 because we have to modularize some files. That is because the pull request was made in other branch.

@alexdeleon
Copy link
Contributor

Ok, but leave the ; to ensure compatibility in the browser. In principle it should work without it but it is better not to risk it :)

@rackdon
Copy link
Contributor Author

rackdon commented Feb 15, 2016

Sorry but it's an autoformat tool, I can't choose that option :(
Each time you run grunt test or grunt build/dist, this tool format all the code.
You can find more information here: https://github.com/feross/standard

@alexdeleon
Copy link
Contributor

Well, if we want to use it on corbel-js we all need to agree to use it otherwise we will be causing git conflicts with each other. Also, I guest we need to make changes in the jsHint config for it not to complain. @rafinskipg @anthanh what do you think?

@rafinskipg
Copy link
Contributor

hi @alexdeleon , we have stopped using jshint in favour of standardjs , the gruntfile now includes the autoformatter so no more space/tab problems. But we are thinking in migrate corbel-js to es6 modules and use babel to ensure browser compatibility and also minify the dist.

The point for the migration of the modules is being able to require isolated files and make better unit tests

@alexdeleon
Copy link
Contributor

Ok then, if it doesn't cause any issues in the browser then lets migrate to this code style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants