Feature: add additional params get hooks and post hook #40
Conversation
…creation get with additional param test breaking
JuraJuki
changed the base branch from
feat/use-post/additional-param
to
master
JuraJuki
changed the title
Resolved conflicts, merged master, and closed #33. Everything can be tracked here now. I realised now.. that this is not you wanted just, forgive me. Merged things in the wrong PR. But in the end, it is the same result. Either everything would have been on #33 or here. Get tests are failing now after the merge. I could manage to solve the issue, all of sudden there is an async await error. |
src/hooks/interfaces/useGetParams.ts
Outdated
| includes?: string[]; | ||
| headers?: { [key: string]: string }; | ||
| additionalUrlParam?: string; | ||
| a: number; |
src/hooks/usePost.ts
Outdated
| @@ -39,7 +48,7 @@ export const usePost = < | |||
| }); | |||
| }); | |||
| }, | |||
| [apiActionHandler, dispatch], | |||
| [apiActionHandler, dispatch, headers], | |||
There was a problem hiding this comment.
@JuraJuki Check the annotation of the PR below this comment. It says that it has a missing dependency!
|
This PR is very meaningful, but it needs some additional work. Currently, it has a few merge conflicts so maybe we start from there? |
…al-params # Conflicts: # src/hooks/useGet.ts # src/hooks/useGetAll.ts # src/hooks/useGetAllControlled.ts # src/json-api-client/ApiActionHandler.ts # src/services/ApiActionCreator/ApiActionCreator.ts # src/services/ApiActionCreator/interfaces/CreateApiActionConfigParam.ts # src/tests/deleteHookTests.test.tsx
…to feat/hooks/additional-params
Yes, merged the conflict's solution. What do you think are the next steps? |
For now, getting the tests to work. Can we use a different approach for the failing test? |
This PR contains additional params for get and post hooks. Its been merged from #33, #40 and master. Going to close PR #33 now. Everything should be tracked here from now on