rename libmetis -> libmetis-gtsam to avoid collision with system libs #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment GTSAM builds its own private libmetis.so from the sources in gtsam/3rdparty/metis. This creates a single-architecture libmetis.so file without ABI number, which breaks the building of a multi-architecture Debian package because GTSAM's libmetis.so file collides with the one from the standard libmetis5 Debian package.
The best fix is probably to first make use of 3rdparty/metis optional (see #309 and #292), as was done already for 3rdparty/Eigen, and ultimately directly rely on libmetis5-dev for development of GTSAM.
Until such more elaborate fixes are in place, this PR renames the 3rdparty libmetis to libmetis-gtsam to make Debian/Ubuntu multi-arch builds possible, and avoid accidentally compiling against headers from 3rdparty/metis, but linking against libmetis.so from libmetis5.
Referencing @jlblancoc for review.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)