#523 - Poetry version fixes #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meliz19
commented
Jan 6, 2025
| @@ -22,6 +22,8 @@ runs: | |||
| default: 3.11.4 | |||
| - name: Install Poetry | |||
| uses: snok/install-poetry@v1 | |||
| with: | |||
| version: 1.8.5 | |||
There was a problem hiding this comment.
I: fixing version until we update Habushu
There was a problem hiding this comment.
Assuming this is the highest pre-2.0 version?
meliz19
commented
Jan 6, 2025
| @@ -4,7 +4,7 @@ FROM docker.io/python:3.11 AS habushu_builder | |||
| RUN python -m ensurepip --upgrade && \ | |||
| pip install poetry && \ | |||
| poetry self add poetry-monorepo-dependency-plugin && \ | |||
| poetry self add poetry-plugin-bundle@1.3.0 | |||
| poetry self add poetry-plugin-bundle | |||
There was a problem hiding this comment.
I: Removing fixed version until we update Habushu (line 5 installs the latest version of poetry)
meliz19
commented
Jan 6, 2025
| @@ -80,6 +80,7 @@ | |||
| <dockerBuilderBase>docker.io/python:3.11</dockerBuilderBase> | |||
| <dockerFinalBase>docker.io/python:3.11-slim</dockerFinalBase> | |||
| <dockerUser>1001</dockerUser> | |||
| <updateDockerfile>false</updateDockerfile> | |||
There was a problem hiding this comment.
I: Turning off habushu so that we can make the fix in the Dockerfiles above
There was a problem hiding this comment.
A: Let's add a POM comment saying why we're turning off the update feature, and when we plan to turn it back on.
ewilkins-csi
approved these changes
Jan 6, 2025
cwoods-cpointe
approved these changes
Jan 6, 2025
meliz19
force-pushed
the
523-fix-poetry-versioning-breakage
branch
from
0d0e628 to
226386b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.