Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add follow me support for Breez Max #38

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

mikeyoon
Copy link
Contributor

Adds support for the follow me feature. One thing I noticed that might need addressing is that I restricted it to the Breez Max. I don't know if this feature is limited to the Max, or if there's a better way to determine follow me compatibility altogether.

@miles267
Copy link

Thanks @mikeyoon. Am so excited to use this on my Breez Max. I’ve found the temp reading at the main air handler up high on wall to read differently than on wall where the BM thermostat is installed. How can we start using this new feature?

@@ -495,6 +519,7 @@ def _get_action(self) -> object:
"fanspeed": self._device["latestAction"]["fanspeed"],
"temp": self._device["latestAction"]["temp"],
"swing": self._device["latestAction"]["swing"],
"followme": self._device["latestAction"]["followme"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in a try exception. Not all device has this feature

if device.get_is_appliance_is_freezepoin_display():
entities.append(
CieloHomeSwitchFreezingPoint(
device, "Freezing Point", device.get_uniqueid() + "FreezingPoint"
)
)

if device.get_device_type() == "BREEZ-MAX":
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must check if the device is support follow-me, not if it's Breeze max. My device support it and i don't have a Breeze-Max.

@bodyscape bodyscape self-assigned this Nov 12, 2023
@audreez
Copy link

audreez commented Nov 14, 2023

are you guys sure only max supports follow me ?

i have breez-plus and breez-eco and they both allow me to use follow me function which changes the temp on midea, can these be added?

@bodyscape
Copy link
Owner

bodyscape commented Nov 14, 2023

@audreez Don't worry, i ask for he change that! It's not for only the breeze-max

@mikeyoon mikeyoon requested a review from bodyscape November 29, 2023 08:20
@bodyscape bodyscape merged commit c2bbf56 into bodyscape:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants