Support email usernames in API access validation #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our LDAP implementation, the username is our email address, which includes both '.' and '@' in them. Of course, an email can have other symbols still, but those two cover the vast majority of cases already. Signed-off-by: Thiago Donato Ferreira <thiago.ferreira@lnls.br>
dmgav
requested changes
Feb 19, 2024
flowln
force-pushed
the
email_username_support
branch
2 times, most recently
from
6666370 to
feb124b
Compare
|
I think it should be |
flowln
force-pushed
the
email_username_support
branch
from
feb124b to
3310eec
Compare
These characters is also allowed in emails. Co-authored-by: Dmitri Gavrilov <46980826+dmgav@users.noreply.github.com> Signed-off-by: Thiago Donato Ferreira <thiago.ferreira@lnls.br>
flowln
force-pushed
the
email_username_support
branch
from
3310eec to
276d6da
Compare
dmgav
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the JSON schema to accept
.,@,-, and+, in usernames.Description
In our LDAP implementation, our email address can be used in the place of the username, and that includes both
.and@in them. Of course, an email can have other symbols still, but those two cover the vast majority of cases already.So, to use
DictionaryAPIAccessControlauthorization together with our LDAP-based authentication, this change is welcome. Also, I can't see how accepting those characters could be an issue, though I know next to nothing about that stuff, so please boop me if I'm wrong 🙂Summary of Changes for Release Notes
Added
Added
.,@,-, and+, to the allowed character list ofBasicAPIAccessControlandDictionaryAPIAccessControlusername validations.How Has This Been Tested?
We tested this change in our local test deploy of HTTP server, and after those changes, we managed to successfully authenticate a user using their email address.