Fix goose configure to only write to config if chat completion check succeeds #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…succeeds Fixes block#997 Update `goose configure` to only write `OLLAMA_HOST` to config if chat completion check succeeds. * Perform chat completion check before setting `OLLAMA_HOST` in the config. * Only set `OLLAMA_HOST` in the config if the chat completion check succeeds. * Update the `configure_provider_dialog` function to reflect these changes. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/997?shareId=XXXX-XXXX-XXXX-XXXX).
salman1993
approved these changes
Feb 5, 2025
|
autogenerated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997
Update
goose configureto only writeOLLAMA_HOSTto config if chat completion check succeeds.OLLAMA_HOSTin the config.OLLAMA_HOSTin the config if the chat completion check succeeds.configure_provider_dialogfunction to reflect these changes.For more details, open the Copilot Workspace session.