Fix: STM32L4 DBGMCU handling #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the parameter in `stm32l4_configure_dbgmcu()` when configuring the DBGMCU
dragonmux
force-pushed
the
fix/stm32l4-dbgmcu-handling
branch
from
43d773e to
ac2605c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we fix an issue with the new DBGMCU handling for the STM32L4-like parts. In the original PR for this, #1882, we accidentally mishandled the device family checks when going to configure the DBGMCU, using the parameter version of
devicerather than theprivstructure version. This results in a NULL dereference and a crash on attach.Your checklist for this pull request
Closing issues
Fixes #1787, closing the final item in the issue.