Fix: ADIv5 handling issues #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect TAR wrap-around behaviour Co-Authored-By: Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de>
…aptors, and switched to issuing a warning when attempting to re-select a multi-drop part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR fixes a couple of bugs that were accidentally introduced a while back in the ADIv5 implementation, and provides a workaround for the ST-Link firmware not supporting multi-drop at all, unlike what the release notes advertise.
The first of the regressions that this fixes is in the ADIv5 memory I/O code where the handling for TAR wrap-around got botched by typo in aa9bb48 (as much as the keys are right next to each other, e is not 3!).
The second regression was accidentally introduced in 44422c9 when SWD multi-drop was refactored and rewritten - most likely due to an oversight.
The ST-Link component of this PR partially fixes/alleviates #1813 but does not resolve the issue laid out in that issue.
Your checklist for this pull request
Closing issues