-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows improvements #85
Conversation
.github/workflows/deploy-prod.yaml
Outdated
EC2-Deploy: | ||
runs-on: ubuntu-latest | ||
environment: | ||
name: ${{ github.ref_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want this to be main
(as is) or PROD
or timeline-report.bitovi-jira.com
?
.github/workflows/deploy-prod.yaml
Outdated
- name: Notify if not latest | ||
if: steps.check_latest.outputs.is_latest == 'false' | ||
run: | | ||
echo "This release is not marked as the latest. No pipeline run." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will prevent rollbacks, do we want to enforce roll-forwards? @justinbmeyer
.github/workflows/deploy.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
environment:
name: ${{ github.ref_name }}
url: ${{ steps.deploy.outputs.vm_url }}
Same comments on env names as in the prod deploy file
.github/workflows/deploy.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with:
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID_JIRA_INTEGRATIONS}}
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY_JIRA_INTEGRATIONS}}
aws_default_region: us-east-1
These should be the (new?) staging env secrets
Initial draft PR
We still need to define how to set the CALLBACK_URL