Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows improvements #85

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Workflows improvements #85

merged 4 commits into from
Sep 17, 2024

Conversation

LeoDiazL
Copy link
Contributor

Initial draft PR

We still need to define how to set the CALLBACK_URL

These environment variables are merged to the .env file quoted in the following order:

Terraform passed env vars ( This is not optional nor customizable )
Repository checked-in env vars - repo_env file as default. (KEY=VALUE style)
Github Vars - Create a variable in your GH Repo - (KEY=VALUE style)
Github Secret - Create a secret in your GH Repo - (KEY=VALUE style)
AWS Secret - Comma separated list of JSON style like '{"key":"value"}' secrets.```

EC2-Deploy:
runs-on: ubuntu-latest
environment:
name: ${{ github.ref_name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want this to be main (as is) or PROD or timeline-report.bitovi-jira.com?

.github/workflows/deploy-prod.yaml Show resolved Hide resolved
Comment on lines 35 to 38
- name: Notify if not latest
if: steps.check_latest.outputs.is_latest == 'false'
run: |
echo "This release is not marked as the latest. No pipeline run."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will prevent rollbacks, do we want to enforce roll-forwards? @justinbmeyer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    environment:
      name: ${{ github.ref_name }}
      url: ${{ steps.deploy.outputs.vm_url }}

Same comments on env names as in the prod deploy file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 with:
        aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID_JIRA_INTEGRATIONS}}
        aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY_JIRA_INTEGRATIONS}}
        aws_default_region: us-east-1

These should be the (new?) staging env secrets

.github/workflows/deploy-prod.yaml Show resolved Hide resolved
@LeoDiazL LeoDiazL marked this pull request as ready for review August 22, 2024 13:26
@DavidNic11 DavidNic11 merged commit d757c6b into main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants