Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add variables for media time remaining, elapsed #121

Merged
merged 5 commits into from
Nov 2, 2021

Conversation

bryce-seifert
Copy link
Member

@bryce-seifert bryce-seifert commented Oct 18, 2021

Add media time elapsed, remaining variables (Closes #119)
Add image file name variable (Closes #123)

@josephdadams josephdadams merged commit 1b0bd37 into bitfocus:master Nov 2, 2021
@nacalai
Copy link

nacalai commented Nov 12, 2021

I find it strange it hasn't been added to the newest versions yet. Any idea why? We'd like to implement this asap :)

@bryce-seifert
Copy link
Member Author

@nacalai A lot of the core devs have been busy lately. It's not just OBS, there's a lot of waiting modules.

Are you on Mac? I could make a build for you if so

@nacalai
Copy link

nacalai commented Nov 12, 2021

@nacalai A lot of the core devs have been busy lately. It's not just OBS, there's a lot of waiting modules.

Are you on Mac? I could make a build for you if so

Running Windows :) That's kind of you. Would be nice to use it on monday

@bryce-seifert
Copy link
Member Author

@nacalai Well looks like it's in the core now :) Let me know how testing goes!

@kjetilpp
Copy link

How to update only this module? Running PI :)

@bryce-seifert
Copy link
Member Author

You are not able to update single modules in companion at this time, only the whole software. Here's the relevant issue.

@estilles
Copy link

You are not able to update single modules in companion at this time, only the whole software. Here's the relevant issue.

Hey @bryce-seifert, I use a workaround on the Raspberry Pi when I want to test a module that I've updated that has no yet been updated in the Companion core.

  • Clone the module repo into the module-local-dev folder within companion
  • Change into that folder, run yarn to install any dependencies
  • Restart Companion

For example:

cd ~/companion/module-local-dev/
git clone https://github.com/bitfocus/companion-module-obs-studio.git
cd companion-module-obs-studio
yarn
sudo systemctl restart companion

@krocheck
Copy link
Member

krocheck commented Nov 13, 2021

Easier option is to edit the root package.json, find the dependency for companion-module-obs-studio, update the tag at the end of the line to the new version, then run a yarn for it to apply that update.

Later on you will need to git reset --hard in the root to do normal updates.

@kjetilpp
Copy link

@estilles Nice, did not know about module-local-dev. So helpful to use that folder, will save me a lot of time, thanks!😄

@bryce-seifert bryce-seifert deleted the 1.0.26 branch November 13, 2021 19:10
@estilles
Copy link

@estilles Nice, did not know about module-local-dev. So helpful to use that folder, will save me a lot of time, thanks!😄

Thanks @kjetilpp. @krocheck's suggestion is really good too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image filename variable Media Time Remaining Variable
6 participants