Provide three options for donation reminder time #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkup
requested review from
rfc2822 and
ArnyminerZ
and removed request for
ArnyminerZ
|
Just a stylistic thing, but have you thought about using segmented buttons? |
Not segmented buttons, but at the start I did have three normal buttons next to each other. The problem I see with that is that some languages might have long words for "month(s)" and then the last button would flow/break into the next line or become ugly in some other way ... |
rfc2822
reviewed
Jan 22, 2025
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/OpenSourcePage.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/RadioButtons.kt
Outdated
Show resolved
Hide resolved
|
New look
|
rfc2822
force-pushed
the
provide-three-options-for-donation-remind-time
branch
from
11e3500 to
3e57108
Compare
rfc2822
pushed a commit
that referenced
this pull request
Jan 27, 2025
* Provide three options for donation reminder time * Move radio buttons to top card; Change strings * Use padding instead of height for radio elements
|
There was an update of the ical4android version, I have taken it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Provide three options for donation reminder time.
Short description
setDontShowto handle different number of monthsRadio Buttons in Compose: https://developer.android.com/develop/ui/compose/components/radio-button
Checklist
Closes https://github.com/bitfireAT/davx5/issues/636