Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP374: update reference.py and secp256k1.py to be executable #1736

Merged

Conversation

jonatack
Copy link
Member

by adding to each a python shebang and changing their file permissions from 644 to 755, as mentioned in #1734 (comment).

These files don't need to be executable in order to run gen_test_vectors.py and run_test_vectors.py but it is helpful to allow developers to invoke them directly.

Before:

$ ./reference.py 
zsh: permission denied: ./reference.py

After:

$ ./reference.py 

Copy link
Contributor

@andrewtoth andrewtoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cce668d

@jonatack jonatack merged commit b15a0a1 into bitcoin:master Jan 2, 2025
4 checks passed
@jonatack jonatack deleted the 2024-12-bip374-make-python-files-executable branch January 2, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants