-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs on using the library fingerprints in HA #599
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1428 1428
=========================================
Hits 1428 1428
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
Edit the ``_get_vehicles()`` function in `account.py#L370-L392 <https://github.com/bimmerconnected/bimmer_connected/blob/master/bimmer_connected/account.py#L370-L392>`_ | ||
and add the following code between ``self._get_oauth_token()`` and ``for brand in CarBrand:``: | ||
Edit ``homeassistant/components/bmw_connected_drive/coordinator.py`` and locate the function ``_async_update_data``. We now have to replace ``await self.account.get_vehicles()``. The ``try .. except`` block should look like this: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder is not available on HA OS or Supervised installs, so good to mention that this is available on Container / Core installs (don't know what your install type is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically the whole thing is referencing the HA dev environment (i.e. running it on your local machine in VS Code). Can I make this somehow clearer with the existing warning to the HA dev environment?
Would you run this also in your local HAOS installation (it would surely mess up a lot of settings)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. then good to mention in the title that this is for Home Assistant development environment. That should be clear then.
Doesn't sound logic to run this in a local HAOS installation.
Proposed change
Updated docs :)
Type of change
Additional information
Checklist