Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): STRF-12475 Use utils.api.cart.postFormData when updating variants in cart #2521

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

jordanarldt
Copy link
Contributor

@jordanarldt jordanarldt commented Dec 16, 2024

What?

Update cart.js to use utils.api.cart.postFormData when updating variant options from the cart page. Using AJAX gives us more control over which headers are sent.

TODO:

  • Update stencil-utils version

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Screenshots (if appropriate)

Screen.Recording.2024-12-16.at.11.46.23.AM.mov

@jordanarldt jordanarldt force-pushed the STRF-12475 branch 5 times, most recently from 1653593 to 80bfaef Compare December 16, 2024 23:02
@jordanarldt jordanarldt changed the title fix(storefront): STRF-12475 Use fetch when updating variants in cart fix(storefront): STRF-12475 Use utils.api.cart.updateCartItemOptions when updating variants in cart Dec 16, 2024
@jordanarldt jordanarldt changed the title fix(storefront): STRF-12475 Use utils.api.cart.updateCartItemOptions when updating variants in cart fix(storefront): STRF-12475 Use utils.api.cart.postFormData when updating variants in cart Dec 17, 2024
Copy link
Contributor

@jairo-bc jairo-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanarldt jordanarldt marked this pull request as ready for review December 17, 2024 21:11
Copy link

@jmwiese jmwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanarldt jordanarldt merged commit bae693f into master Dec 26, 2024
2 checks passed
@jordanarldt jordanarldt deleted the STRF-12475 branch December 26, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants