Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leedave/ap rename #49

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

leedave
Copy link

@leedave leedave commented Jul 24, 2023

Not ready yet. Dont put it in your main branch yet.
Just posted so you know someone's working on it. More updates will be added to this pr.

Feature to Rename Wifi AP

Current state

  • Added Menu Point
  • Added Text Editor
  • Reads out ap.config.txt and adds to text editor
  • Returns to menu after using text editor

In development

  • Save data from text editor into ap.config.txt
  • Sometimes the AP name has random chars at the end, need to figure out why

@leedave
Copy link
Author

leedave commented Jul 25, 2023

Now it's finished. Hope it helps.

The random character issue still occassionally appears, but I noticed that this is a bug you have already made an issue for. My advice would be switch to using FlipperFormat. Will write a comment into your issue.

@DeSirektmwm8
Copy link

Good job. Can you please write a path how to replace the old fies with yours on the flipper?

@leedave
Copy link
Author

leedave commented Jul 25, 2023

It's still up to the author to accept the Pull-Request, if it fits him.

But as you asked so kindly, there's two option to get a preview of it

  1. Use the latest Roguemaster FW, it has it included
  2. I've uploaded a compiled version with my changes in it. You can download it and copy it to your device (replace the file "SD Card/apps/GPIO/evil_portal.fap")
    Preview Version

@DeSirektmwm8
Copy link

Works great, thanks a lot.

@leedave
Copy link
Author

leedave commented Jul 28, 2023

So I decided to add something more 😄

Now it also has a selector that allows you to change the Portal's HTML file in the app.
Just make sure you copy all the portal html files to apps_data/evil_portal/html

My preview fap is also updated for those interested.
Screenshot-20230728-121641

@@ -1,65 +1,6 @@
# Community Portals

Do you have a great portal that you would like to share? Please submit a pull request placing your portal in this folder. It'd be great to see what the community can come up with! Please also add yourself to this readme so your contribution is recognized.
Copy link
Contributor

@CodyTolene CodyTolene Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally removed a few sections below:

  • Limitations
  • Contributors
  • Disclaimer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this update, it looks like we can remove the portals folder at the root altogether. It's now empty. And then we can move that portion of the readme back to the main readme.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodyTolene
Do you need changes from my side or is this already resolved?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep these suggestions are for your work here. It looks like you can remove the portals folder after your changes. It also looks like you removed a portion of the README that was unintended.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme was just copied to the new folder along with all html files, no changes applied to the text.

I also think the portals folder could be removed, but just for those who may be looking for it (many PR etc.), I placed a new readme file in the empty portals folder with a link to the new location of the html files & readme.

@CodyTolene
Copy link
Contributor

CodyTolene commented Aug 18, 2023

@leedave
This is testing out well! Approved per my tests. A few comments above that will likely get this through faster with @bigbrodude6119. Nice work.

For anyone else looking to test this here is the fap:
evil_portal.zip

Edit: Preview below
Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants