-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leedave/ap rename #49
base: main
Are you sure you want to change the base?
Conversation
Now it's finished. Hope it helps. The random character issue still occassionally appears, but I noticed that this is a bug you have already made an issue for. My advice would be switch to using FlipperFormat. Will write a comment into your issue. |
Good job. Can you please write a path how to replace the old fies with yours on the flipper? |
It's still up to the author to accept the Pull-Request, if it fits him. But as you asked so kindly, there's two option to get a preview of it
|
Works great, thanks a lot. |
@@ -1,65 +1,6 @@ | |||
# Community Portals | |||
|
|||
Do you have a great portal that you would like to share? Please submit a pull request placing your portal in this folder. It'd be great to see what the community can come up with! Please also add yourself to this readme so your contribution is recognized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you accidentally removed a few sections below:
- Limitations
- Contributors
- Disclaimer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this update, it looks like we can remove the portals
folder at the root altogether. It's now empty. And then we can move that portion of the readme back to the main readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodyTolene
Do you need changes from my side or is this already resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep these suggestions are for your work here. It looks like you can remove the portals folder after your changes. It also looks like you removed a portion of the README that was unintended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme was just copied to the new folder along with all html files, no changes applied to the text.
I also think the portals folder could be removed, but just for those who may be looking for it (many PR etc.), I placed a new readme file in the empty portals folder with a link to the new location of the html files & readme.
@leedave For anyone else looking to test this here is the fap: |
Not ready yet. Dont put it in your main branch yet.
Just posted so you know someone's working on it. More updates will be added to this pr.
Feature to Rename Wifi AP
Current state
In development