feat(api): #3121 scdl integration script #3124
Merged
+454
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
461OceanBd
force-pushed
the
3121-scdl-integration-script
branch
5 times, most recently
from
5242912 to
f7f7fae
Compare
- renamed script
- added types for parseParams
- rename variable
- corrected type error
461OceanBd
force-pushed
the
3121-scdl-integration-script
branch
from
18996b5 to
208be39
Compare
mxmeunier
reviewed
Jan 28, 2025
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.ts
Outdated
Show resolved
Hide resolved
- rename variable
- type factorization
- explicited type
- explicited describe name
- mocked fs
- del brackets
- refacto to test on thing in each test
- renamed var
Comment on lines
-35
to
+40
| rowOffsetStr: number | string = 0, | ||
| rowOffset: number | string = 0, | ||
| ) { | ||
| await this.validateGenericInput(file, producerSlug, exportDate); | ||
| const rowOffset = typeof rowOffsetStr === "number" ? rowOffsetStr : parseInt(rowOffsetStr); | ||
| const parsedRowOffset = typeof rowOffset === "number" ? rowOffset : parseInt(rowOffset); | ||
| const fileContent = fs.readFileSync(file); | ||
| const { entities, errors } = ScdlGrantParser.parseExcel(fileContent, pageName, rowOffset); | ||
| const { entities, errors } = ScdlGrantParser.parseExcel(fileContent, pageName, parsedRowOffset); |
There was a problem hiding this comment.
Ils étaient pas bien les noms de variables ?
There was a problem hiding this comment.
C'était pour répondre à la remarque de Maxime sur le fait que c'est bizarre que la variable rowOffsetStr s'appelle comme ça alors qu'on peut aussi mettre un number
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
packages/api/src/interfaces/scripts/ScdlDataIntegration.node.test.ts
Outdated
Show resolved
Hide resolved
- refacto: change parseParams type, object instead of array
461OceanBd
force-pushed
the
3121-scdl-integration-script
branch
from
0d3221d to
cf533e0
Compare
- changed console.trace
- del afterEach
- del redundant test
- renamed libel
- refacto to use code with cli
alice-telescoop
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script Node permettant d'intégrer des fichiers scdl par batch avec gestion d'erreur appropriées.
Nb :