Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for choiceColumn in choice questions. Ref #378 #379

Closed
wants to merge 2 commits into from

Conversation

ruscoder
Copy link
Member

I've added support for choiceColumn for choice questions. It's fully backward compatible because if no choiceColumn passed - the default getDisplay is used.

The usecase example:

  - text: Diagnoses
    type: choice
    linkId: diagnoses
    repeats: true
    answerValueSet: http://hl7.org/fhir/ValueSet/icd-10
    choiceColumn:
      - path: code
        forDisplay: true

@ruscoder ruscoder requested a review from vesnushka November 22, 2024 22:34
@ir4y
Copy link
Member

ir4y commented Nov 22, 2024

@ruscoder the same feature was implemented as part of https://github.com/beda-software/fhir-emr/pull/376/files#diff-606d3917dcaa9881fbf14f31e368ce6169f49d6c9b8bff6c3841798dc783ece3

It seems that that implementation is simpler than the one you provided.
Could you please review that implementation and provide your feedback.

@ruscoder
Copy link
Member Author

It seems that that implementation is simpler than the one you provided. Could you please review that implementation and provide your feedback

I tried to solve it in a general way for not only Codings, but according to the specification, it does not make sense for non-Coding. Actually, your solution is good. Let's extract it from your PR as a separate PR that can be merged separately.

@ruscoder ruscoder closed this Nov 25, 2024
@ruscoder ruscoder deleted the 378-choice-column branch November 25, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants