Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: CI housekeeping #1042

Merged
merged 3 commits into from
Jun 3, 2024
Merged

GHA: CI housekeeping #1042

merged 3 commits into from
Jun 3, 2024

Conversation

tleedjarv
Copy link
Contributor

No description provided.

tleedjarv added 3 commits June 2, 2024 20:30
This does not (yet) mean that compatibility with 2.48 is intentionally
broken. The testing is currently doing little more than waste resources.
@gdt
Copy link
Collaborator

gdt commented Jun 2, 2024

I'm ok with dropping testing with 2.48. However, I think it merits saying something on users@, which I can do, which is "While we don't intend to break compatibility with 2.48, we are no longer testing against it. Anyone using 2.48 is reminded that it is very very past time to upgrade."

Are we declaring 5.1 irrelevant/broken? We have been trying to verify on all. are we going to document that unison doesn't work on 5.1? Something else?

@tleedjarv
Copy link
Contributor Author

I'm ok with dropping testing with 2.48. However, I think it merits saying something on users@, which I can do, which is "While we don't intend to break compatibility with 2.48, we are no longer testing against it. Anyone using 2.48 is reminded that it is very very past time to upgrade."

I don't think it is necessary but you are free to do so, of course.

Are we declaring 5.1 irrelevant/broken? We have been trying to verify on all. are we going to document that unison doesn't work on 5.1? Something else?

No, not directly. I don't think there's any point in verifying against all versions. Despite the horror stories, there's normally no random breakage from version to version. That's why I removed most of the 4.x versions, too. With 5.x, it is still experimental ("somewhat experimental" is the phrase used by the upstream) and will probably be for another year (that is the current upstream expectation). Testing against the latest 5.x only seems appropriate and sufficient. This does not mean that earlier 5.x stops working but if a future 5.x makes breaking changes then I see no reason to support any earlier 5.x versions. I'd maintain support starting from the first stable 5.x version (expected in about a year).

@gdt gdt merged commit 53a2d0d into bcpierce00:master Jun 3, 2024
28 checks passed
@tleedjarv tleedjarv deleted the gha-cleanup branch June 5, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants