Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Charly Molter <charly@molter.io>
Signed-off-by: Baptiste Collard <9626829+bcollard@users.noreply.github.com>
  • Loading branch information
bcollard and lahabana authored Apr 10, 2024
1 parent 4697e85 commit e969603
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/docker-build-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ jobs:
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
username: ${{ vars.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_API_KEY }}

- name: Build and push backend
uses: docker/build-push-action@v5
Expand All @@ -30,7 +30,7 @@ jobs:
context: ./api
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.DOCKERHUB_USERNAME }}/kuma-demo-be:latest
tags: ${{ vars.DOCKER_REPOSITORY || vars.DOCKER_USERNAME }}/kuma-demo-be:latest

- name: Build and push frontend
uses: docker/build-push-action@v5
Expand All @@ -39,7 +39,7 @@ jobs:
context: ./app
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.DOCKERHUB_USERNAME }}/kuma-demo-fe:latest
tags: ${{ vars.DOCKER_REPOSITORY || vars.DOCKERHUB_USERNAME }}/kuma-demo-fe:latest

- name: Build and push postgres
uses: docker/build-push-action@v5
Expand All @@ -48,7 +48,7 @@ jobs:
context: ./api/db/postgresql
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.DOCKERHUB_USERNAME }}/postgres:latest
tags: ${{ vars.DOCKERHUB_REPOSITORY || vars.DOCKERHUB_USERNAME }}/postgres:latest

- name: Build and push redis
uses: docker/build-push-action@v5
Expand All @@ -57,4 +57,4 @@ jobs:
context: ./api/db/redis
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.DOCKERHUB_USERNAME }}/kuma-redis:latest
tags: ${{ vars.DOCKER_REPOSITORY || vars.DOCKER_USERNAME }}/kuma-redis:latest

0 comments on commit e969603

Please sign in to comment.