Added lookupService and catsAPI service to further wrap bc gov apis

bcgov · Jan 3, 2025 · ebc547a · ebc547a
1 parent 9d7b323
commit ebc547a
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 12 deletions.
diff --git a/aws/lambdas/locations/get-locations/index.ts b/aws/lambdas/locations/get-locations/index.ts
@@ -1,5 +1,6 @@
 import { APIGatewayEvent, APIGatewayProxyResult, Context } from "aws-lambda";
 import { HttpService } from "../../../services/httpService";
+import { LookupService } from "../../../services/lookupService";
 import SecretsManagerService from "../../../services/secretsManagerService";
 
 export const handler = async (
@@ -10,16 +11,14 @@ export const handler = async (
 
   try {
     const smService = new SecretsManagerService();
-    const secretStringJson = await smService.getSecret(
-      process.env.FILE_SERVICES_CLIENT_SECRET_NAME!
-    );
-    const { baseUrl, username, password } = JSON.parse(secretStringJson);
     const httpService = new HttpService();
+    const lookupService = new LookupService(httpService, smService);
+
+    lookupService.init();
 
-    await httpService.init(baseUrl, username, password);
     const queryParams = event.queryStringParameters || {};
 
-    const data = await httpService.get(event.path, queryParams);
+    const data = await lookupService.get(event.path, queryParams);
 
     return {
       statusCode: 200,

diff --git a/aws/lambdas/locations/get-rooms/index.ts b/aws/lambdas/locations/get-rooms/index.ts
@@ -1,5 +1,6 @@
 import { APIGatewayEvent, APIGatewayProxyResult, Context } from "aws-lambda";
 import { HttpService } from "../../../services/httpService";
+import { LookupService } from "../../../services/lookupService";
 import SecretsManagerService from "../../../services/secretsManagerService";
 
 export const handler = async (
@@ -10,16 +11,14 @@ export const handler = async (
 
   try {
     const smService = new SecretsManagerService();
-    const secretStringJson = await smService.getSecret(
-      process.env.FILE_SERVICES_CLIENT_SECRET_NAME!
-    );
-    const { baseUrl, username, password } = JSON.parse(secretStringJson);
     const httpService = new HttpService();
+    const lookupService = new LookupService(httpService, smService);
+
+    lookupService.init();
 
-    await httpService.init(baseUrl, username, password);
     const queryParams = event.queryStringParameters || {};
 
-    const data = await httpService.get(event.path, queryParams);
+    const data = await lookupService.get(event.path, queryParams);
 
     return {
       statusCode: 200,

diff --git a/aws/services/lookupService.ts b/aws/services/lookupService.ts
@@ -0,0 +1,35 @@
+import { IHttpService } from "./httpService";
+import SecretsManagerService from "./secretsManagerService";
+
+export class LookupService {
+  constructor(
+    private httpService: IHttpService,
+    private smService: SecretsManagerService
+  ) {}
+
+  async init() {
+    console.log(
+      `Retrieving credentials for ${process.env.FILE_SERVICES_CLIENT_SECRET_NAME}.`
+    );
+
+    const secretStringJson = await this.smService.getSecret(
+      process.env.FILE_SERVICES_CLIENT_SECRET_NAME!
+    );
+
+    console.log(`Credentials retrieved: ${secretStringJson}`);
+
+    console.log(`Initializing httpService`);
+
+    const { baseUrl, username, password } = JSON.parse(secretStringJson);
+
+    await this.httpService.init(baseUrl, username, password);
+
+    console.log("httpService initialized.");
+  }
+
+  async get(url: string, queryParams?: Record<string, unknown>) {
+    console.log(`Sending GET request for ${url}...`);
+
+    return await this.httpService.get(url, queryParams);
+  }
+}