Skip to content

Commit

Permalink
- Removed passing of application/json header since it is passed on ea…
Browse files Browse the repository at this point in the history
…ch request

- Used string substitution as per recommendation
  • Loading branch information
Ronaldo Macapobre committed Feb 12, 2025
1 parent 49f3adb commit 4d55f72
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 14 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/actions/deploy-lambda/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,8 @@ runs:
shell: bash
run: |
echo "Lambda: ${{ inputs.lambda }}"
RESOURCE=$(echo "${{ inputs.lambda }}" | cut -d'/' -f1)
LAMBDA=$(echo "${{ inputs.lambda }}" | cut -d'/' -f2)
echo "RESOURCE=$RESOURCE" >> $GITHUB_ENV
echo "LAMBDA=$LAMBDA" >> $GITHUB_ENV
echo "RESOURCE=${{ matrix.lambda }%%/*}" >> $GITHUB_ENV
echo "LAMBDA=${{ matrix.lambda }##*/}" >> $GITHUB_ENV
echo "IMAGE_NAME=$RESOURCE.$LAMBDA" >> $GITHUB_ENV
- name: Set reusable variables
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/publish-lambdas.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@ jobs:
id: parse
run: |
echo "Lambda: ${{ matrix.lambda }}"
RESOURCE=$(echo "${{ matrix.lambda }}" | cut -d'/' -f1)
LAMBDA=$(echo "${{ matrix.lambda }}" | cut -d'/' -f2)
echo "RESOURCE=$RESOURCE" >> $GITHUB_ENV
echo "LAMBDA=$LAMBDA" >> $GITHUB_ENV
echo "RESOURCE=${{ matrix.lambda }%%/*}" >> $GITHUB_ENV
echo "LAMBDA=${{ matrix.lambda }##*/}" >> $GITHUB_ENV
- name: Setup Image Metadata
id: meta
Expand Down
3 changes: 0 additions & 3 deletions aws/services/httpService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ export class HttpService implements IHttpService {
password,
},
httpsAgent,
headers: {
"Content-Type": "application/json",
},
});
}

Expand Down
3 changes: 0 additions & 3 deletions aws/tests/services/httpService.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ describe("HttpService", () => {
password,
},
httpsAgent: expect.anything(),
headers: {
"Content-Type": "application/json",
},
})
);
});
Expand Down

0 comments on commit 4d55f72

Please sign in to comment.