Skip to content

Commit

Permalink
Fix ios version usage
Browse files Browse the repository at this point in the history
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
  • Loading branch information
jleach committed Feb 24, 2022
1 parent 618ee29 commit fe82364
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,12 @@ jobs:
run: |
for i in $(ls ../patch); do git apply ../patch/$i; done
# - name: Bump Build No.
# run: |
# scripts/bump_ios_build.sh
- name: Bump Build No.
env:
CURRENT_PROJECT_VERSION: ${{ github.run_number }}
MARKETING_VERSION: "1.0.1"
run: |
scripts/bump_ios_build.sh
# Actual environment variables are not being picked up
# by the build so they're put into an .env file.
Expand All @@ -137,9 +140,6 @@ jobs:
- name: Build
working-directory: bifold/ios
env:
CURRENT_PROJECT_VERSION: ${{ github.RUN_NUMBER }}
MARKETING_VERSION: "1.0.1"
run: |
xcodebuild \
-workspace AriesBifold.xcworkspace \
Expand Down Expand Up @@ -311,7 +311,7 @@ jobs:
env:
PLAY_STORE_JKS_ALIAS: ${{ secrets.PLAY_STORE_JKS_ALIAS }}
PLAY_STORE_JKS_PASSWD: ${{ secrets.PLAY_STORE_JKS_PASSWD }}
VERSION_CODE: ${{ github.RUN_NUMBER }}
VERSION_CODE: ${{ github.run_number }}
VERSION_NAME: "1.0.0"
run: |
./gradlew bundleRelease
Expand Down
6 changes: 2 additions & 4 deletions scripts/bump_ios_build.sh
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
#!/bin/sh
set -xaou pipefail

VERSION_STRING="1.0.1"

# /usr/libexec/PlistBuddy \
# -c "Set :CFBundleVersion ${GITHUB_RUN_NUMBER}" "$1"

# /usr/libexec/PlistBuddy \
# -c "Set :CFBundleShortVersionString ${VERSION_STRING}" "$1"

agvtool new-version ${GITHUB_RUN_NUMBER}
agvtool new-marketing-version ${VERSION_STRING}
agvtool new-version ${CURRENT_PROJECT_VERSION}
agvtool new-marketing-version ${MARKETING_VERSION}

0 comments on commit fe82364

Please sign in to comment.