Update CI to Xcode 15.1 on macos 13.0 #818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karim-alweheshy
force-pushed
the
karim/update-xcode-version
branch
from
4bd353d to
f6d47ee
Compare
karim-alweheshy
changed the title
karim-alweheshy
force-pushed
the
karim/update-xcode-version
branch
from
ce3ab22 to
9edcbcd
Compare
added 9 commits
December 27, 2023 10:54
karim-alweheshy
force-pushed
the
karim/update-xcode-version
branch
from
18fc767 to
1f12400
Compare
karim-alweheshy
force-pushed
the
karim/update-xcode-version
branch
from
42afdc4 to
2080455
Compare
…mic libs otherwise point to the .zip file so it can be unzipped and unpack the dylib .framework. before this solution it points to the static .framework
karim-alweheshy
force-pushed
the
karim/update-xcode-version
branch
from
3043cca to
1f69a72
Compare
|
A step for bazel 7 migration |
Closed
luispadron
reviewed
Dec 29, 2023
There was a problem hiding this comment.
The xcspec changes / ci look good to me.
I'm not sure about the project changes though, it seems like the path was broken? @thiagohmcruz @jerrymarino
There was a problem hiding this comment.
Was this change intentional? Seems to break the path
There was a problem hiding this comment.
without this path change it was pointing to a static framework when it should point to the dynamic framework. This dynamic framework can at times be compressed into a zip i.e. doesn't exist yet on disk. in that case i added the zip to be unzipped later in the same script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CI runners to macos-13
Update Xcode to 15.1.0 from 14.2.0
Update min iOS version to 12.0 from 10.0 and 11.0 and remove Host-App pre 12.0
Updated iOS sdk to 17.2 and devices to sims from the runner
Update swift_version from 5.1 to 5.9
Update xcodeproj installer, as it was pointing to a static lib for dynamic lib compilation and fixed path to remove
//Updated compile frameworks to the correct arch
ios-sim-arm64-x86_64Updated third party libs to be on the right arch
ios-sim-arm64-x86_64