Skip to content

Commit

Permalink
Remove extended modulemap from swiftc_inputs (#900)
Browse files Browse the repository at this point in the history
The normal modulemap was added in
#894 and the extended
modulemap is only for the objective-c part of the library so we
shouldn't add it for the swiftc_inputs
  • Loading branch information
luispadron authored Aug 21, 2024
1 parent a15336e commit c81d4a0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rules/library.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -954,6 +954,8 @@ def apple_library(
generated_swift_header_name = module_name + "-Swift.h"

if module_map:
# Extended modulemap contains the Swift module and its generated header
# It is to be used by the Objective-C part of the library.
extend_modulemap(
name = module_map + ".extended." + name,
destination = "%s.extended.modulemap" % name,
Expand All @@ -963,7 +965,6 @@ def apple_library(
tags = _MANUAL,
)
module_map = "%s.extended.modulemap" % name
swiftc_inputs.append(module_map)

# Note: this needs to go here, in order to virtualize the extended module
framework_vfs_overlay(
Expand Down

0 comments on commit c81d4a0

Please sign in to comment.