Merge pull request #1664 from bancorprotocol/fix/batch

Redirect if showCart is false
bancorprotocol · Feb 6, 2025 · 12569e2 · 12569e2
2 parents 05a8ecc + 72fd087
commit 12569e2
Show file tree

Hide file tree

Showing 14 changed files with 9 additions and 3 deletions.
diff --git a/...screenshots/simulator/recurring/Recurring_limit_limit/simulator-input-price.png b/...screenshots/simulator/recurring/Recurring_limit_limit/simulator-input-price.png
diff --git a/e2e/screenshots/strategy/disposable/Disposable_buy_limit/create/form.png b/e2e/screenshots/strategy/disposable/Disposable_buy_limit/create/form.png
diff --git a/e2e/screenshots/strategy/disposable/Disposable_buy_limit/create/my-strategy.png b/e2e/screenshots/strategy/disposable/Disposable_buy_limit/create/my-strategy.png
diff --git a/e2e/screenshots/strategy/disposable/Disposable_sell_limit/create/my-strategy.png b/e2e/screenshots/strategy/disposable/Disposable_sell_limit/create/my-strategy.png
diff --git a/e2e/screenshots/strategy/disposable/Disposable_sell_range/create/my-strategy.png b/e2e/screenshots/strategy/disposable/Disposable_sell_range/create/my-strategy.png
diff --git a/e2e/screenshots/strategy/disposable/Disposable_sell_range/deposit/form.png b/e2e/screenshots/strategy/disposable/Disposable_sell_range/deposit/form.png
diff --git a/e2e/screenshots/strategy/recurring/Recurring_limit_limit/create/my-strategy.png b/e2e/screenshots/strategy/recurring/Recurring_limit_limit/create/my-strategy.png
diff --git a/e2e/screenshots/strategy/recurring/Recurring_limit_limit/deposit/form.png b/e2e/screenshots/strategy/recurring/Recurring_limit_limit/deposit/form.png
diff --git a/e2e/screenshots/strategy/recurring/Recurring_limit_range/create/my-strategy.png b/e2e/screenshots/strategy/recurring/Recurring_limit_range/create/my-strategy.png
diff --git a/e2e/screenshots/strategy/recurring/Recurring_range_limit/create/my-strategy.png b/e2e/screenshots/strategy/recurring/Recurring_range_limit/create/my-strategy.png
diff --git a/e2e/screenshots/strategy/recurring/Recurring_range_range/create/my-strategy.png b/e2e/screenshots/strategy/recurring/Recurring_range_range/create/my-strategy.png
diff --git a/src/components/core/menu/mainMenu/MainMenuCart.tsx b/src/components/core/menu/mainMenu/MainMenuCart.tsx
@@ -25,6 +25,8 @@ export const MainMenuCart = () => {
     return () => window.removeEventListener('storage', handler);
   });
 
+  if (!user) return;
+
   return (
     <Link
       id="menu-cart-link"

diff --git a/src/libs/routing/routes/cart.ts b/src/libs/routing/routes/cart.ts
@@ -1,9 +1,15 @@
-import { createRoute } from '@tanstack/react-router';
+import { createRoute, redirect } from '@tanstack/react-router';
 import { rootRoute } from 'libs/routing/routes/root';
 import { CartPage } from 'pages/cart';
+import config from 'config';
 
 export const cartPage = createRoute({
   getParentRoute: () => rootRoute,
   path: '/cart',
   component: CartPage,
+  loader: () => {
+    if (!config.ui.showCart) {
+      throw redirect({ to: '/' });
+    }
+  },
 });
diff --git a/src/pages/cart/index.tsx b/src/pages/cart/index.tsx
@@ -121,8 +121,6 @@ export const CartPage = () => {
     }
   };
 
-  if (!config.ui.showCart) return;
-
   if (!strategies.length) {
     return (
       <section className="px-content pb-30 xl:px-50 mx-auto grid max-w-[1280px] flex-grow content-start gap-16 pt-20">