-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send worker changes to master #42294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parsing support for new worker related syntax
… into worker_change
Each pair of send-receive is associated with an index called eventIndex
Implement new worker semantics - Part I
[Worker Change] Fix failing worker `on fail` parser test
lochana-chathura
requested review from
hevayo,
warunalakshitha,
sameerajayasoma and
hasithaa
as code owners
March 13, 2024 09:32
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/WDChannels.java
Outdated
Show resolved
Hide resolved
…nal/scheduling/WDChannels.java Co-authored-by: Sasindu Alahakoon <47134066+SasinduDilshara@users.noreply.github.com>
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/WDChannels.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/WDChannels.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/WDChannels.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/WDChannels.java
Outdated
Show resolved
Hide resolved
13 tasks
Refactor worker message passing
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
HindujaB
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Team/jBallerina
All the issues related to BIR, JVM backend code generation and runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject. This PR adds support for the following features,
Fixes #41699 Fixes #41953 Fixes #41968 Fixes #42004
This PR includes collective changes from the subsequent PRs.
on fail
parser test #41767on fail
clause #41741error:NoMessage
iff all receives have it in the alternate receive #42050Approach
n/a
Samples
n/a
Remarks
Sequence diagram behavior: #42151 (comment)
Check List