Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix legacy mocking failure #41686

Conversation

Thevakumar-Luheerathan
Copy link
Member

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #40731

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Dilhasha
Dilhasha previously approved these changes Nov 13, 2023
Co-authored-by: Fathima Dilhasha <dilhasha.uom@gmail.com>
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Nov 28, 2023
Copy link

github-actions bot commented Dec 2, 2023

Closed PR due to inactivity for more than 18 days.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ae5102c) 76.68% compared to head (7faa8ea) 76.73%.
Report is 230 commits behind head on master.

Files Patch % Lines
...o2/ballerinalang/compiler/desugar/MockDesugar.java 20.00% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41686      +/-   ##
============================================
+ Coverage     76.68%   76.73%   +0.05%     
- Complexity    52671    52727      +56     
============================================
  Files          2881     2878       -3     
  Lines        198686   198747      +61     
  Branches      25822    25838      +16     
============================================
+ Hits         152357   152506     +149     
+ Misses        37892    37808      -84     
+ Partials       8437     8433       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thevakumar-Luheerathan Thevakumar-Luheerathan merged commit 04c07e4 into ballerina-platform:master Dec 4, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MockDesugar throws NPE with legacy function mocking
2 participants