-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix value conversion error for inline record creation with special characters #41640
Fix value conversion error for inline record creation with special characters #41640
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41640 +/- ##
============================================
+ Coverage 76.68% 76.72% +0.04%
- Complexity 52671 52689 +18
============================================
Files 2880 2879 -1
Lines 198580 198657 +77
Branches 25801 25809 +8
============================================
+ Hits 152282 152422 +140
+ Misses 37876 37807 -69
- Partials 8422 8428 +6 ☔ View full report in Codecov by Sentry. |
… into fix-record-special-char
20c18d1
to
d30752f
Compare
… into fix-record-special-char
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
langlib/langlib-test/src/test/resources/test-src/valuelib_test.bal
Outdated
Show resolved
Hide resolved
0974f3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
$subject
Fixes #41633
Approach
As we use the decoded identifiers in the value conversions, the generated record value creators should have the same representation in the switch cases. This PR fixes it by using the
Utils.unescapeBallerina()
API.Samples
Remarks
Check List