-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of "\" escape character in identifier names #41540
Fix handling of "\" escape character in identifier names #41540
Conversation
e7baa84
to
34b6f71
Compare
8c1e270
to
2491ece
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## identifier_unescaping #41540 +/- ##
========================================================
Coverage ? 77.51%
Complexity ? 58584
========================================================
Files ? 3438
Lines ? 219217
Branches ? 28922
========================================================
Hits ? 169917
Misses ? 39886
Partials ? 9414 ☔ View full report in Codecov by Sentry. |
b6573ea
to
e0c181a
Compare
e0c181a
to
a1a1d03
Compare
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Closed PR due to inactivity for more than 18 days. |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
a1a1d03
to
75ec733
Compare
75ec733
to
80d27fc
Compare
80d27fc
to
7a9fbb0
Compare
3138ef2
into
ballerina-platform:identifier_unescaping
Purpose
Fixes #41507
Fixes #41635
Approach
Samples
Remarks
Note that unescaping more than once would break the code for some scenarios.
e.g. consider:
a\\3
. (Here user intends to escape the backslash using backslash)After first unescape:
a\3
(Correct)After second unescape
a3
(Wrong)After third unescape
a3
(Wrong)Check List