Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.7.x] Include resource path for client object resource methods #41265

Conversation

NipunaMadhushan
Copy link
Contributor

Purpose

API doc generation does not work properly when there are resource methods inside a client object. This will fix the issue.

Fixes #41264

@NipunaMadhushan NipunaMadhushan changed the title Include resource path for client object resource methods [2201.7.x] Include resource path for client object resource methods Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 90.00% and no project coverage change.

Comparison is base (aadb761) 76.46% compared to head (0e4de47) 76.46%.
Report is 66 commits behind head on 2201.7.x.

Additional details and impacted files
@@             Coverage Diff              @@
##             2201.7.x   #41265    +/-   ##
============================================
  Coverage       76.46%   76.46%            
- Complexity      55244    55328    +84     
============================================
  Files            3377     3389    +12     
  Lines          208045   208494   +449     
  Branches        26934    26968    +34     
============================================
+ Hits           159085   159434   +349     
- Misses          40208    40293    +85     
- Partials         8752     8767    +15     
Files Changed Coverage Δ
...g/diagramutil/connector/models/connector/Type.java 73.77% <50.00%> (+1.67%) ⬆️
...l/connector/models/connector/types/RecordType.java 96.42% <92.85%> (-3.58%) ⬇️
...il/connector/models/connector/types/UnionType.java 100.00% <100.00%> (ø)
.../main/java/org/ballerinalang/docgen/Generator.java 91.83% <100.00%> (+1.19%) ⬆️

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Sep 6, 2023
@NipunaMadhushan NipunaMadhushan force-pushed the fix-api-resource-path-2201.7.x branch from b744966 to c8cbeb6 Compare September 7, 2023 04:24
@NipunaMadhushan NipunaMadhushan force-pushed the fix-api-resource-path-2201.7.x branch from c8cbeb6 to 4ad01cc Compare September 7, 2023 04:26
udda1996
udda1996 previously approved these changes Sep 7, 2023
keizer619
keizer619 previously approved these changes Sep 7, 2023
@NipunaMadhushan NipunaMadhushan merged commit ea84cc9 into ballerina-platform:2201.7.x Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants