Implement bal tool search
#40758
Merged
Implement bal tool search
#40758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azinneera
reviewed
Jun 19, 2023
| settings = Settings.from(); | ||
| } | ||
| CentralAPIClient client = new CentralAPIClient(RepoUtils.getRemoteRepoURL(), | ||
| initializeProxy(settings.getProxy()), |
There was a problem hiding this comment.
@Thevakumar-Luheerathan is there anything more for the proxy implementation?
There was a problem hiding this comment.
We need to pass the username password too... Check
There was a problem hiding this comment.
@Thevakumar-Luheerathan please check if it's correct now.
azinneera
reviewed
Jun 19, 2023
| } | ||
| } catch (CentralClientException e) { | ||
| String errorMessage = e.getMessage(); | ||
| if (null != errorMessage && !"".equals(errorMessage.trim())) { |
There was a problem hiding this comment.
Let's throw a generic error if the message is not present.
There was a problem hiding this comment.
Added a generic error
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #40758 +/- ##
============================================
- Coverage 76.93% 76.42% -0.51%
- Complexity 53747 55274 +1527
============================================
Files 3332 3386 +54
Lines 200289 208284 +7995
Branches 25654 26959 +1305
============================================
+ Hits 154086 159185 +5099
- Misses 37819 40324 +2505
- Partials 8384 8775 +391
☔ View full report in Codecov by Sentry. |
gayaldassanayake
force-pushed
the
bal-tool-search
branch
from
186acca to
e720106
Compare
gayaldassanayake
force-pushed
the
bal-tool-search
branch
from
e720106 to
8cd301c
Compare
azinneera
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$ subject
Related to #40264
The output is identical to the bal search command output except for the newly added
IDfield.Approach
Samples
Remarks
Check List