Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.4.1-stage] Update visible endpoint generation to identify client object files with annotations #39809

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

kanushka
Copy link
Contributor

@kanushka kanushka commented Mar 7, 2023

Purpose

Update visible endpoint generation to identify client object files with annotations.

Fixes #39657

Approach

Semantic API doesn't send CLIENT qualifier for client object node with annotations. This PR will skip annotation from the node and request Semantic TypeSymbol just only for the client object.

service /abc on new http:Listener(9090) {

    @display {
        label: "InternalClientService",
    }
    InternalClient inEp3;

    function init() returns error? {
        self.inEp3 = check new InternalClient("http://example.com/internal/1");
    }

    resource function get repos(string orgName, int max = 5) returns string|error? {

    }

}

In the above example @display { label: "InternalClientService", } InternalClient inEp3 node won't get the CLIENT qualifier. But just creating a new node with InternalClient inEp3 will send the CLIENT qualifier.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@kanushka kanushka requested a review from hevayo as a code owner March 7, 2023 05:58
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (2201.4.1-stage@956a778). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             2201.4.1-stage   #39809   +/-   ##
=================================================
  Coverage                  ?   76.82%           
  Complexity                ?    53532           
=================================================
  Files                     ?     3323           
  Lines                     ?   199781           
  Branches                  ?    25580           
=================================================
  Hits                      ?   153474           
  Misses                    ?    37970           
  Partials                  ?     8337           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madushajg madushajg merged commit aa20b25 into ballerina-platform:2201.4.1-stage Mar 8, 2023
@kanushka
Copy link
Contributor Author

kanushka commented Mar 8, 2023

Send changes to the new 2201.4.1-stage branch #39822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants