Add non public access tests

ballerina-platform · Mar 14, 2024 · 71061b3 · 71061b3
1 parent 49c9b56
commit 71061b3
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/...src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java b/...src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
@@ -1355,9 +1355,10 @@ private BType checkTupleType(BTupleType tupleType, BLangListConstructorExpr list
     }
 
     private BTupleType createNewTupleType(Location pos, List<BType> memberTypes, AnalyzerData data) {
+        SymbolEnv symbolEnv = data.env;
         BTypeSymbol tupleTypeSymbol =
-                Symbols.createTypeSymbol(SymTag.TUPLE_TYPE, Flags.PUBLIC, Names.EMPTY,
-                        data.env.enclPkg.symbol.pkgID, null, data.env.scope.owner, pos, SOURCE);
+                Symbols.createTypeSymbol(SymTag.TUPLE_TYPE, Flags.PUBLIC, Names.EMPTY, symbolEnv.enclPkg.symbol.pkgID,
+                        null, symbolEnv.scope.owner, pos, SOURCE);
         List<BTupleMember> members = new ArrayList<>();
         memberTypes.forEach(m ->
                 members.add(new BTupleMember(m, Symbols.createVarSymbolForTupleMember(m))));

diff --git a/...st/src/test/java/org/ballerinalang/test/bala/constant/ListConstantInBalaNegativeTest.java b/...st/src/test/java/org/ballerinalang/test/bala/constant/ListConstantInBalaNegativeTest.java
@@ -56,8 +56,14 @@ public void testNegative() {
                 "cannot update 'readonly' value of type '[1,\"f\",\"g\"] & readonly'", 30, 5);
         BAssertUtil.validateError(compileResult, i++, "incompatible types: expected '(1|\"f\"|\"g\")', found 'string'",
                 30, 12);
-        BAssertUtil.validateError(compileResult, i++, "undefined symbol 'l10'", 34, 17);
-        BAssertUtil.validateError(compileResult, i++, "undefined symbol 'l11'", 35, 18);
+        BAssertUtil.validateError(compileResult, i++, "undefined symbol 'l13'", 34, 17);
+        BAssertUtil.validateError(compileResult, i++, "undefined symbol 'l14'", 35, 18);
+        BAssertUtil.validateError(compileResult, i++, "attempt to refer to non-accessible symbol 'l10'", 39, 15);
+        BAssertUtil.validateError(compileResult, i++, "undefined symbol 'l10'", 39, 15);
+        BAssertUtil.validateError(compileResult, i++, "attempt to refer to non-accessible symbol 'l11'", 40, 29);
+        BAssertUtil.validateError(compileResult, i++, "undefined symbol 'l11'", 40, 29);
+        BAssertUtil.validateError(compileResult, i++, "attempt to refer to non-accessible symbol 'l12'", 41, 18);
+        BAssertUtil.validateError(compileResult, i++, "undefined symbol 'l12'", 41, 18);
         Assert.assertEquals(compileResult.getErrorCount(), i);
     }
 

diff --git a/...-unit-test/src/test/resources/test-src/bala/test_bala/constant/list_constant_negative.bal b/...-unit-test/src/test/resources/test-src/bala/test_bala/constant/list_constant_negative.bal
@@ -31,6 +31,12 @@ function testInvalidUpdates() {
 }
 
 function testUndefinedMemberAccess() {
-    float[] _ = foo:l10;
-    string[] _ = foo:l11;
+    float[] _ = foo:l13;
+    string[] _ = foo:l14;
+}
+
+function testNonPublicConstAccess() {
+    int[] _ = foo:l10;
+    [int, int, boolean] _ = foo:l11;
+    string[] _ = foo:l12;
 }
diff --git a/...a-unit-test/src/test/resources/test-src/bala/test_projects/test_project/list_constant.bal b/...a-unit-test/src/test/resources/test-src/bala/test_projects/test_project/list_constant.bal
@@ -27,3 +27,6 @@ public const IntArr l6 = [1, 2, 3];
 public const [int, string...] l7 = [1, "f", "g"];
 public const (string|int)[][] l8 = [[1, "2", 3], [4, 5, 6]];
 public const [(string[]|int[])...] l9 = [[1, 2, 3], ["4", "5", "6"]];
+const int[] l10 = [1, 2, 3];
+const [int, int, boolean] l11 = [1, 2, true];
+const l12 = l1;