Store api-key values in hashed format #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afitzek
force-pushed
the
store-api-keys-hashed
branch
from
0e200a0 to
d5343e1
Compare
flesler
approved these changes
Apr 24, 2018
Page-
requested changes
Apr 25, 2018
src/sbvr-api/permissions.coffee
Outdated
| @@ -47,6 +56,12 @@ parsePermissions = do -> | |||
| if value?.bind? | |||
| return { bind: value.bind + bindsLength } | |||
|
|
|||
| exports.hashApiKey = hashApiKey = (apiKey) -> | |||
There was a problem hiding this comment.
This should be replaced with sbvrUtils.sbvrTypes.SHA.validate really, to make sure it has the same behaviour (although it might make sense to have a validateSync or something)
This stores the api key values as sha256 hashes. The database values are prefixed with 'SHA256:HEX:' to indicate, which hash algorithm and which encoding are used. Change-Type: major Signed-off-by: Andreas Fitzek <andreas@resin.io>
afitzek
force-pushed
the
store-api-keys-hashed
branch
from
bab7d64 to
ccf9a2b
Compare
|
@afitzek please let’s discuss what we’re going to do with the delta server before merging this, this is a serious blocker for the new deltas. |
Page-
reviewed
May 5, 2018
| @@ -42,6 +42,8 @@ memoizedCompileRule = memoize( | |||
|
|
|||
| db = null | |||
|
|
|||
| exports.hashApiKey = permissions.hashApiKey | |||
There was a problem hiding this comment.
Everything from permissions is already exported below via an _.extend(exports, permissions)
petrosagg
reviewed
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stores the api key values as sha256 hashes. The database values are prefixed with 'SHA256:HEX:' to indicate, which hash algorithm and which encoding are used.
Depends-On: balena-io-modules/sbvr-types#14
Change-Type: major
Signed-off-by: Andreas Fitzek andreas@resin.io