S3 receive filepath #449
Merged
S3 receive filepath #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 89.45% 89.29% -0.17%
==========================================
Files 20 20
Lines 6080 6127 +47
==========================================
+ Hits 5439 5471 +32
- Misses 641 656 +15
|
waahm7
reviewed
Aug 19, 2024
graebm
reviewed
Aug 20, 2024
graebm
reviewed
Aug 20, 2024
graebm
reviewed
Aug 22, 2024
source/s3_meta_request.c
Outdated
| fclose(meta_request->recv_file); | ||
| meta_request->recv_file = NULL; | ||
| if (finish_result.error_code && meta_request->recv_file_delete_on_failure) { | ||
| /* Ignore the failure. Attempt to delete */ |
There was a problem hiding this comment.
trivial: I was confused by "ignore the failure". I was like "but we ARE paying attention to the failure! It's delete_on_failure, and the operation is failing, so delete!". Maybe you meant that we're ignoring any errors from aws_file_delete()???
Suggested change
| /* Ignore the failure. Attempt to delete */ |
source/s3_meta_request.c
Outdated
| @@ -1781,7 +1843,21 @@ static void s_s3_meta_request_event_delivery_task(struct aws_task *task, void *a | |||
| if (meta_request->meta_request_level_running_response_sum) { | |||
| aws_checksum_update(meta_request->meta_request_level_running_response_sum, &response_body); | |||
There was a problem hiding this comment.
I know this isn't part of your PR. But I see 😬 we're not checking aws_checksum_update() for error
graebm
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.