Work around container build issue #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Apr 9, 2024
rauteric
reviewed
Apr 9, 2024
The plugins don't have a link-time dependency on libcuda.so, so only check for the library if we actually need it (ie, we're building the functional tests). This works around a problem building on containers, where it's likely that the libcuda.so library is either not there or stubbed out (to be pulled up from the base AMI later). Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
force-pushed
the
bugfix/disable-tests-by-default
branch
from
97fa0e3 to
0db224e
Compare
|
After talking with Raghu, skip the commit that disables the tests for now for two reasons:
|
rajachan
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around an issue building in containers due to libcuda.so being stubbed out by only checking for libcuda if functional tests are built, and disabling the functional tests by default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.