Add -lm to library list for plugins #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tuner uses the log2 function that is defined in libm, but we were relying on someone else to pull in libm, which is technically wrong. Checking for what library provides libm fixes this issue, with the side effect of adding a -lm to the link line for the libnccl-net plugin. This is not strictly needed, but linkers also will do the right thing most of the time and not actually include that dependency in the list of libraries that must be loaded for the plugin. So this is a lot less configure code compared to each plugin having its own LIBS list, for the same outcome. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
|
Thanks to @aws-nslick for pointing this out. |
AmedeoSapio
approved these changes
Apr 9, 2024
|
Thanks Brian, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tuner uses the log2 function that is defined in libm, but we were relying on someone else to pull in libm, which is technically wrong. Checking for what library provides libm fixes this issue, with the side effect of adding a -lm to the link line for the libnccl-net plugin. This is not strictly needed, but linkers also will do the right thing most of the time and not actually include that dependency in the list of libraries that must be loaded for the plugin. So this is a lot less configure code compared to each plugin having its own LIBS list, for the same outcome.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.