Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform cleanup #675

Merged
merged 1 commit into from
May 12, 2022

Conversation

bryan-aguilar
Copy link
Contributor

Description: Adds a cleanup target and script that can be used in the case where a GitHub actions workflow is cancelled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of overlap with executeTerraformTest.sh in the setup stage that could be factored out, but that can be tracked to work later.

@bryan-aguilar
Copy link
Contributor Author

Added issue to track #676

@bryan-aguilar bryan-aguilar merged commit 5147f39 into aws-observability:terraform May 12, 2022
@bryan-aguilar bryan-aguilar deleted the addCleanup branch May 12, 2022 16:30
bryan-aguilar added a commit that referenced this pull request May 13, 2022
* Add terraform cleanup (#675)

* Add logging around log query

* add loging around json validation
bryan-aguilar added a commit to bryan-aguilar/aws-otel-test-framework that referenced this pull request May 23, 2022
Kausik-A added a commit that referenced this pull request May 31, 2022
* Update APPLY_EXIT on success and failure (#695)

* Update APPLY_EXIT on success and failure

* Put APPLY_EXIT back inside conditonal

* Add terraform cleanup (#675)

* removed testcases related to sigv4authextension

Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com>
bryan-aguilar added a commit that referenced this pull request Jun 8, 2022
* Add terraform cleanup (#675)

* Add logging to structured logs validator (#677)

* Add logging around log query

* add loging around json validation

* Print entire processing report instead of messages (#679)

* print entire report

* add newline

* Add visbility into query (#681)

* add visbility into query

* fix formatting

* Log check result fails and improve failed schema output (#683)

* add logging

* Add more logging, failed results

* Update validator/src/main/java/com/amazon/aoc/validators/AbstractStructuredLogValidator.java

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants