Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing theorems and solutions to C02 S01 #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaearon
Copy link

@gaearon gaearon commented Feb 1, 2025

There's two problems, as reported here and here:

  • The list of allowed theorems seems (to me, anyway!) insufficient. Maybe it's possible to solve it with just these (not sure!) but there's also the second problem, which is...
  • These exercises are missing solutions. This is frustrating because I don't know if I'm missing something or the book has a mistake.

This PR attempts to fix both issues.

Note I have not verified the book itself compiles locally so the syntax for including solutions (the -- SOLUTIONS: thing) is my best guess based on the format used earlier in the file.

Thanks for consideration!

@@ -351,12 +351,44 @@ example (a b : ℝ) : (a + b) * (a - b) = a ^ 2 - b ^ 2 := by
#check mul_sub a b c
#check add_mul a b c
#check add_sub a b c
#check sub_add a b c
#check sub_self a
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are unnecessary, it would be nice to still get the second half merged (with the edits that prove they're unnecessary :)

#check sub_sub a b c
#check add_zero a
-- QUOTE.

end

-- SOLUTIONS:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my guess at the syntax, so pls don't merge without testing that I didn't bork the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant