Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
iansuvak committed Feb 7, 2025
1 parent 8b0a503 commit df1e07b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion signature-aggregator/aggregator/aggregator.go
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,8 @@ func (s *SignatureAggregator) marshalRequest(
}

func (s *SignatureAggregator) unmarshalResponse(responseBytes []byte) (blsSignatureBuf, error) {
if len(responseBytes) == 0 { // empty responses are valid and indicate the node has not seen the message
// empty responses are valid and indicate the node has not seen the message
if len(responseBytes) == 0 {
return blsSignatureBuf{}, nil
}
var sigResponse sdk.SignatureResponse
Expand Down
2 changes: 1 addition & 1 deletion signature-aggregator/aggregator/aggregator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ func TestUnmarshalResponse(t *testing.T) {
},
{
name: "nil slice",
appResponseBytes: []byte{},
appResponseBytes: nil,
expectedSignature: blsSignatureBuf{},
},
{
Expand Down

0 comments on commit df1e07b

Please sign in to comment.