Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly configure STM32 devices from cmake options #937

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

UncleGrumpy
Copy link
Collaborator

Configures main system clock and flash size based on the target device.
The console uart may be configured by using the -DAVM_CFG_CONSOLE= option, or
for Nucleo devices the on board TTL->USB-COM can be configured with the
-DBOARD=nucleo cmake option. Previously these values were hard coded in the C
sources and needed to be changed manually if a device other than the default
target was used.

Closes #454

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Copy link
Collaborator

@fadushin fadushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except one whitespace question in the docs

doc/src/build-instructions.md Outdated Show resolved Hide resolved
@UncleGrumpy UncleGrumpy force-pushed the stm32_dev_config branch 2 times, most recently from fb2a914 to bddb487 Compare November 12, 2023 23:05
Moves several auto discovered tool paths and configuration options to the
`ADVANCED` category, usefull in UI tools like `ccmake` and IDEs that provide
GUI configuration for `cmake` options. This cleans up the default menu to only
show configuration options for configuring AtomVM itself, while leaving fine
tuned toolchain options availabe inder the "Advanced" menus.

Signed-off-by: Winford <winford@object.stream>
Configures main system clock and flash size based on the target device.
The console uart may be configured by using the `-DAVM_CFG_CONSOLE=` option, or
for Nucleo devices the on board TTL->USB-COM can be configured with the
`-DBOARD=nucleo` cmake option. Previously these values were hard coded in the C
sources and needed to be changed manually if a device other than the default
target was used.

Closes atomvm#454

Signed-off-by: Winford <winford@object.stream>
@fadushin fadushin merged commit 11f0da3 into atomvm:master Nov 13, 2023
@UncleGrumpy UncleGrumpy deleted the stm32_dev_config branch December 31, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STM32 port has potential conflicts in hard coded peripheral configuration.
2 participants