Validation to prevent all field types as @hidden #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github.com:atlassian-labs/nadel into GQLGW-3245-ValidationToPreventAllFieldTypesAsHidden
gnawf
reviewed
Dec 5, 2024
lib/src/main/java/graphql/nadel/validation/NadelFieldValidation.kt
Outdated
Show resolved
Hide resolved
lib/src/main/java/graphql/nadel/validation/NadelSchemaValidationError.kt
Outdated
Show resolved
Hide resolved
…245-ValidationToPreventAllFieldTypesAsHidden
bbakerman
previously approved these changes
Dec 9, 2024
bbakerman
reviewed
Dec 9, 2024
lib/src/test/kotlin/graphql/nadel/validation/NadelFieldValidationTest.kt
Show resolved
Hide resolved
gnawf
previously approved these changes
Dec 9, 2024
…245-ValidationToPreventAllFieldTypesAsHidden
gnawf
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @hidden directive from Nadel has the effect of hiding a field from the overall schema. It’s possible for a customer to have a type where every field has a @hidden directive. This produces invalid GraphQL.
This PR takes care of this issue and returns an error whenever such a query is given.