Delete dead code and better test name (#481)

atlassian-labs · Dec 19, 2023 · 8fcd024 · 8fcd024
1 parent ff668e4
commit 8fcd024
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/test/src/test/kotlin/graphql/nadel/tests/EngineTestHook.kt b/test/src/test/kotlin/graphql/nadel/tests/EngineTestHook.kt
@@ -98,9 +98,7 @@ internal fun getTestHook(fixture: TestFixture): EngineTestHook? {
         "new batch polymorphic hydration with rename",
         "new batch polymorphic hydration when hook returns null 1",
         "new batch polymorphic hydration actor fields are in the same service return types implement same interface",
-        "new complex-identified-by-with-rename",
-        "new new batching single source id",
-        "new new batching multiple source ids going to different services",
+        "new complex identified by with rename",
         ->
             name.removePrefix("new ")
         else -> name

diff --git a/.../resources/fixtures/hydration/complex identified by/complex-identified-by-with-rename.yml b/.../resources/fixtures/hydration/complex identified by/complex-identified-by-with-rename.yml
@@ -1,4 +1,4 @@
-name: "complex-identified-by-with-rename"
+name: "complex identified by with rename"
 enabled: true
 overallSchema:
   UserService: |

diff --git a/...es/fixtures/new hydration/complex identified by/new-complex-identified-by-with-rename.yml b/...es/fixtures/new hydration/complex identified by/new-complex-identified-by-with-rename.yml
@@ -1,6 +1,7 @@
-name: "new complex-identified-by-with-rename"
+name: "new complex identified by with rename"
 enabled: true
 overallSchema:
+  # language=GraphQL
   UserService: |
     type Query {
       users(id: [UserInput]): [User]
@@ -13,6 +14,7 @@ overallSchema:
       id: ID
       name: String
     }
+  # language=GraphQL
   Issues: |
     type Query {
       issues: [Issue]
@@ -31,6 +33,7 @@ overallSchema:
       )
     }
 underlyingSchema:
+  # language=GraphQL
   UserService: |
     type Query {
       users(id: [UserInputUnderlying]): [User]
@@ -46,6 +49,7 @@ underlyingSchema:
       siteId: ID
       name: String
     }
+  # language=GraphQL
   Issues: |
     type Query {
       issues: [Issue]
@@ -60,6 +64,7 @@ underlyingSchema:
       authorId: UserRef
       id: ID
     }
+# language=GraphQL
 query: |
   query {
     issues {
@@ -74,6 +79,7 @@ variables: { }
 serviceCalls:
   - serviceName: "Issues"
     request:
+      # language=GraphQL
       query: |
         query {
           issues {
@@ -155,6 +161,7 @@ serviceCalls:
       }
   - serviceName: "UserService"
     request:
+      # language=GraphQL
       query: |
         query ($v0: [UserInputUnderlying]) {
             users(id: $v0) {
@@ -193,6 +200,7 @@ serviceCalls:
       }
   - serviceName: "UserService"
     request:
+      # language=GraphQL
       query: |
         query ($v0: [UserInputUnderlying]) {
             users(id: $v0) {