Implement Managed Client MQTTnet extension #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new column Guid. Column Guid is used for storing message IDs. Message ID is the unique identification for every successful send message to the MQTT broker. Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
astarte-packet-id
branch
2 times, most recently
from
3bd01b0 to
03fae2e
Compare
harlem88
requested changes
Apr 23, 2024
osmanhadzic
force-pushed
the
astarte-packet-id
branch
3 times, most recently
from
f732c07 to
bcb1c52
Compare
osmanhadzic
force-pushed
the
astarte-packet-id
branch
4 times, most recently
from
337063c to
3b3f8dc
Compare
nedimtokic
suggested changes
Apr 24, 2024
osmanhadzic
force-pushed
the
astarte-packet-id
branch
from
3b3f8dc to
3bb859e
Compare
nedimtokic
approved these changes
Apr 24, 2024
harlem88
reviewed
Apr 24, 2024
|
In some commits message you write |
Refactor `Connect` method in `AstarteMqttTransport`. Refactor fallback strategy to implement ManagedClient storage. Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
Refactor method `Disconnect` in `AstarteDevice` to async `Disconnect` Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
Refactor method for `StreamData` for individual and aggregate data to `Astarte` Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
Update methods calls `StreamData` for individual and aggregate object data Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
astarte-packet-id
branch
from
9e0dbe2 to
5bbbcc1
Compare
harlem88
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement extension Managed Client for MQTTNet library.
Managed Client extension implement package id, strategy for fallout messages sent to MQTT broker.
Added column guid in AstarteFailedMessages table, column is type Guid and represent messageId
Refactor strategy for fallback messages.
Remove method
HandlePropertiesFailedPublishand implement interfaceIManagedMqttClientStorage.Refactor method for
Connect,DisconnectandDoSendMqttMessageto broker with methods from Managed Client.Refactor methods to async methods:
DisconnectStreamDatafor individual and aggregate messagesAdapt Unit and E2E tests.
Adapt SDK example.